bulk.yml depth is passed to xargs #337
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will override any --depth=NNN passed on the command line
|
Looking briefly at the way the API are called, either the full I would also have assumed that arguments passed via the command-line would take precedence as well but looking at the implementation, it is possible that this might not be the case as the parsing of the bulk keys calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing bulk import, any
depth: 100value added to thebulk.ymlis currently ignored and you have to use--depth=100on the command line.This attempts to fix that issue.
This fix works, BUT it now overrides any value passed on the command-line (which probably should take precedence)?
However, at this point in the code, I can't check
xargfor the presence of any-Domero.import.depthcommand, since this is always there with the default of 4.Not quite sure where the "right" place is to fix this?
cc @sbesson @joshmoore @dominikl